[VarDumper] Use Unicode Control Pictures #12411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a not directly related commit to this: |
|
The effect of this change (see symfony/symfony-standard#732 also) is that if an application has a call to |
a36a707 to
2516118
Compare
|
👍 |
5b20399 to
fa4c084
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
to symfony/symfony-standard
that referenced
this pull request
Nov 9, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- remove inline dump() declaration | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT | Doc PR | ~ Replaced by symfony/symfony#12411 Commits ------- 532ccaf remove inline dump() declaration
fabpot
added a commit
that referenced
this pull request
Nov 9, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [VarDumper] Use Unicode Control Pictures | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I wasn't satisfied with how control chars where dumped, until I found the [Unicode Control Pictures](http://www.unicode.org/charts/PDF/U2400.pdf). This PR takes advantage of them:  Commits ------- 6258ae8 [DebugBundle] remove README.md 50021bd [Debug] No gc_collect_cycles(), it's costly and can segfault b592e90 [VarDumper] inline dump() function loading cd076e4 [VarDumper] Use Unicode Control Pictures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't satisfied with how control chars where dumped, until I found the Unicode Control Pictures.
This PR takes advantage of them: