[Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions #12433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure Propel follows semver good enough for this in version |
|
Considering that Propel 1.6 is still the latest version and that there has been no recent activity on Propel, I don't see the need for the change. Let the Propel guys decide when see fit. |
|
@fabpot The latest version is 1.7.1. |
|
Maybe @marcj knows more about the versions and can take a look at this (if it's really an issue). |
|
Propel follows semver. |
|
I used the same version constraint as in https://github.com/propelorm/PropelBundle/blob/1.4/composer.json#L13 |
|
@fabpot ping |
|
going to merge it in 2.3. |
|
Thank you @hason. |
fabpot
added a commit
that referenced
this pull request
Nov 17, 2014
…opel1 versions (hason) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #12433). Discussion ---------- [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions Commits ------- 0bd19aa [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.