[Security] User refreshment from identical users provider type #12465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| // if a UsernameNotFoundException has been thrown, there are providers | ||
| // associated with the token, but none able to refresh it | ||
| if (null !== $lastException) { |
There was a problem hiding this comment.
This breaks CI. Previously, if you hadn't got any userProvider registered there, the code shoud throw an error. Now it retirns null.
There was a problem hiding this comment.
Where do you see this line breaks CI? I don't see any break there https://travis-ci.org/symfony/symfony/jobs/41113847 :/
Previously, if you hadn't got any userProvider registered there, , the code shoud not throw an error : https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L173.
Previously the code return null.
| foreach ($exceptions as $exception) { | ||
| list($notFound, $provider) = $exception; | ||
| $this->logger->warning(sprintf('Username "%s" could not be found from "%s" provider.', $notFound->getUsername(), get_class($provider))); | ||
| } | ||
| } |
There was a problem hiding this comment.
There is a missing return here, like the current code.
|
closing in favour of #21791 |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [SecurityBundle] only pass relevant user provider | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #4498, #12465, #20401, #21737 | License | MIT | Doc PR | There is no need for the context listener to be aware of all the configured user providers. It must only use the provider for the current firewall (the one identified by the context key passed to the constructor) to refresh the user from the session. Commits ------- d97e07f [SecurityBundle] only pass relevant user provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are using two privoders with the same supported class but with different users, there is a faill because the first
UsernameNotFoundExceptionwill stop the refresh processus.