File upload is broken in Laravel 5 when submitting a form without... #12483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecting a file My tests revealed that with this tweek the problem described at this issue are resolved: laravel/framework#6189 I don't make unit tests, but this will no more break my code flow.
|
This is my first pull request to Symfony, could someone help me? |
|
well generally PRs aren't accepted without tests if tests are really required. |
|
@jonathanpmartins : also you do need to follow the instructions in this file. https://github.com/symfony/symfony/blob/master/CONTRIBUTING.md |
|
Thank you for your attention! Reading the Contributing.md file... |
| @@ -94,7 +94,7 @@ protected function convertFileInformation($file) | |||
|
|
|||
| if ($keys == self::$fileKeys) { | |||
| if (UPLOAD_ERR_NO_FILE == $file['error']) { | |||
| $file = null; | |||
| $file = []; | |||
There was a problem hiding this comment.
still using array() syntax
|
New pull request open. #12486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...selecting a file!
My tests revealed that with this tweek the problem described at this issue are resolved: laravel/framework#6189
I don't make unit tests, but this will no more break my code flow.
I'm not sure if this is the real deal!