Remove all calls to call_user_func() #12520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8c9e00 to
256d14b
Compare
|
It seems like your php removal from travis is in two pull requests: #12522 I think it fits better in the other PR. |
a398fe5 to
fb43172
Compare
|
|
||
| call_user_func(array($this->getParameter('baz_class'), 'configureStatic1'), $instance); | ||
| $baz[1] = 'configureStatic1'; |
There was a problem hiding this comment.
are you sure that the dumper will dump it this way ? I don't see the update changing the dump. Be careful when updating test fixtures
fb43172 to
fd266c7
Compare
|
I must withdraw this PR because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to replace all occurences of
call_user_func()by plain PHP. This is one less function call, and one less depth level in the stack. With it, I also propose that we agree on never usingcall_user_func()in Sf 3.0, since there is always an equivalent faster PHP syntax.