[2.6] Remove possible call_user_func() #12532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -929,7 +929,7 @@ public function offsetGet($option) | |||
| // dependency | |||
| // BEGIN | |||
| $this->calling[$option] = true; | |||
| $value = call_user_func($normalizer, $this, $value); | |||
| $value = $normalizer($this, $value); | |||
There was a problem hiding this comment.
these could both be array() format callables, this won't work?
There was a problem hiding this comment.
no they cannot. See the typehint on setNormalizer, and the detection of lazy options. Both are enforcing the usage of a Closure
|
👍 |
|
btw, similar calls could be removed in 2.3 (the 2.6 branch has moved the logic to a different class in the component, but it is the same) |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2014
This PR was merged into the 2.6 branch. Discussion ---------- [2.6] Remove possible call_user_func() | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Remove possible call_user_func() introduced in 2.6 Commits ------- 1de4920 [2.6] Remove possible call_user_func()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove possible call_user_func() introduced in 2.6