Fix error page preview tests #12540
Closed
Fix error page preview tests #12540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption_controller (mpdude) This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #12147). Discussion ---------- [TwigBundle] Fix error page preview for custom twig.exception_controller | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12147 | License | MIT | Doc PR | n/a The `testErrorPageAction()` always used the `showAction()` of TwigBundle's `ExceptionController`. You can, however, configure an alternate controller by setting `twig.exception_controller`. Thus, in order to get a proper preview, we need to forward to this configured controller (which may be the default one). This requires us to pass an additional parameter to `ExceptionController::showAction` to be able to get the *error* page even if configured otherwise in the constructor. (The other approach would have been to fiddle around with `ExceptionController`'s `debug` flag through a setter when going through the preview action, but that would have been even more messy.) Commits ------- 2065e00 [TwigBundle] Fix error page preview for custom twig.exception_controller
This adds an <abbr> element having a descriptive title that displays the form element's type class name.
…(kix) This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #12268). Discussion ---------- [DX] [Form] [WebProfiler] Added abbrs with type classes | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none This adds an `<abbr/>` element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes? Looks like this:  Commits ------- 0d20753 [DX] [Form] [WebProfiler] Added abbrs with type classes
|
Dang, picked the wrong branch. Disregard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12147 (comment) and following comments there.