-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Test components using their lowest possible deps #12542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1c78903
to
aea19d6
Compare
aea19d6
to
01c7086
Compare
01c7086
to
1326971
Compare
Nice work |
1326971
to
1a4dec7
Compare
1a4dec7
to
4146c0b
Compare
All |
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 15, 2014
…s-grekas) This PR was squashed before being merged into the 2.3 branch (closes #12542). Discussion ---------- Test components using their lowest possible deps | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Once composer/composer#3450 is merged, we'll see if our deps are correct, and ensure that is kept over time by testing each component with its lowest possible deps. Commits ------- 25fef27 Test components using their lowest possible deps
It would be far more accurate to test lowest possible deps for all major versions (2.3, 2.4, ...), see #12969 (diff). |
fabpot
added a commit
that referenced
this pull request
Dec 16, 2014
…nicolas-grekas, fabpot) This PR was merged into the 2.5 branch. Discussion ---------- [2.5] Test components using their lowest possible deps | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #12542 Commits ------- b1b5cca Test lowest versions of dependencies 88d524e Merge remote-tracking branch 'symfony/2.3' into lowest-25 206ebc7 minor #12542 Test components using their lowest possible deps (nicolas-grekas) 25fef27 Test components using their lowest possible deps
nicolas-grekas
added a commit
that referenced
this pull request
Dec 16, 2014
…as, fabpot) This PR was merged into the 2.6 branch. Discussion ---------- [2.6] Test lowest versions of dependencies | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- a29ffa8 [2.6] Test lowest versions of dependencies 5e6959b Merge remote-tracking branch 'symfony/2.5' into lowest-26 b2e0a80 minor #12998 [2.5] Test components using their lowest possible deps (nicolas-grekas, fabpot) b1b5cca Test lowest versions of dependencies 88d524e Merge remote-tracking branch 'symfony/2.3' into lowest-25 206ebc7 minor #12542 Test components using their lowest possible deps (nicolas-grekas) 25fef27 Test components using their lowest possible deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once composer/composer#3450 is merged, we'll see if our deps are correct, and ensure that is kept over time by testing each component with its lowest possible deps.