[FrameworkBundle] backport #12489 #12550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 23, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
This backports the improved error message from #12489 if the built-in web server binary could not be found. |
| @@ -29,7 +30,7 @@ class ServerRunCommand extends ContainerAwareCommand | |||
| */ | |||
| public function isEnabled() | |||
| { | |||
| if (PHP_VERSION_ID < 50400) { | |||
| if (PHP_VERSION_ID < 50400 || defined('HHVM_VERSION')) { | |||
There was a problem hiding this comment.
This has initially been done in #10786 for 2.4 and above.
af192cd to
556eff1
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 28, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] backport #12489 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 556eff1 backport #12489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.