[DX] [HttpKernel] Use "context" argument when logging route in RouterListener #12594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I also had this change on my todo list. IMO should be merged into 2.3 |
|
👍 @iltar I think it was done this way because those messages were created before the PSR. Moving stuff to the context is indeed a good idea. Can you work on another PR for 2.7? Thanks. |
|
Thank you @iltar. |
fabpot
added a commit
that referenced
this pull request
Jan 3, 2015
…route in RouterListener (iltar) This PR was merged into the 2.7 branch. Discussion ---------- [DX] [HttpKernel] Use "context" argument when logging route in RouterListener | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT When using the "fingers_crossed" option, I only log stuff when a certain level is reached. I found the matched route with parameters to be extremely useful. The only problem was, that it gets dumped in a string, which reduces readability significantly when having multiple parameters. I've used the context argument to provide the additional information so it becomes easier to read. Especially for formatters that use the context, such as the HtmlFormatter, can really use this. *I've done a quick check and noticed that almost always the information is dumped in the message, while I think it should be in the context. Is this something that should be changed in general?* Commits ------- 448c03f [HttpKernel] RouterListener uses "context" argument when logging route
|
@fabpot you mean this one for 2.3? This is merged into 2.7. Or were you pointing at the usages of the context? |
|
@iltar Sorry, I meant doing another PR for other places where we could move parameters to the context instead of embedding them into a string. |
|
I should be able to make some time next week(s), I'll submit a PR when done. Do you want me to base them off the 2.3 branch? |
|
@iltar It should be done on 2.7. Thanks. |
fabpot
added a commit
that referenced
this pull request
Jan 16, 2015
…rs (iltar) This PR was squashed before being merged into the 2.7 branch (closes #13418). Discussion ---------- [DX] Attempt to improve logging messages with parameters | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12594 (comment) | License | MIT | Doc PR | n/a This PR is a follow-up of #12594 `[DX] [HttpKernel] Use "context" argument when logging route in RouterListener`. I have attempted to improve the log messages, as well as updating the usage context. I wasn't sure if the log messages should end with a `.` or not, if so I can update all messages to confirm a standard. Commits ------- ea80c9b [DX] Attempt to improve logging messages with parameters
fabpot
added a commit
to symfony/event-dispatcher
that referenced
this pull request
Jan 16, 2015
…rs (iltar) This PR was squashed before being merged into the 2.7 branch (closes #13418). Discussion ---------- [DX] Attempt to improve logging messages with parameters | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#12594 (comment) | License | MIT | Doc PR | n/a This PR is a follow-up of #12594 `[DX] [HttpKernel] Use "context" argument when logging route in RouterListener`. I have attempted to improve the log messages, as well as updating the usage context. I wasn't sure if the log messages should end with a `.` or not, if so I can update all messages to confirm a standard. Commits ------- ea80c9b [DX] Attempt to improve logging messages with parameters
fabpot
added a commit
to symfony/http-kernel
that referenced
this pull request
Jan 16, 2015
…rs (iltar) This PR was squashed before being merged into the 2.7 branch (closes #13418). Discussion ---------- [DX] Attempt to improve logging messages with parameters | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#12594 (comment) | License | MIT | Doc PR | n/a This PR is a follow-up of #12594 `[DX] [HttpKernel] Use "context" argument when logging route in RouterListener`. I have attempted to improve the log messages, as well as updating the usage context. I wasn't sure if the log messages should end with a `.` or not, if so I can update all messages to confirm a standard. Commits ------- ea80c9b [DX] Attempt to improve logging messages with parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the "fingers_crossed" option, I only log stuff when a certain level is reached. I found the matched route with parameters to be extremely useful. The only problem was, that it gets dumped in a string, which reduces readability significantly when having multiple parameters.
I've used the context argument to provide the additional information so it becomes easier to read. Especially for formatters that use the context, such as the HtmlFormatter, can really use this.
I've done a quick check and noticed that almost always the information is dumped in the message, while I think it should be in the context. Is this something that should be changed in general?