some random fixes #126
some random fixes #126
Conversation
| @@ -235,7 +235,6 @@ EOF; | |||
| if ($processed->contains($sDefinition)) { | |||
| continue; | |||
| } | |||
| $processed->offsetSet($sDefinition); | |||
There was a problem hiding this comment.
This change will break things as the $processed object is not populated with processed definition anymore.
There was a problem hiding this comment.
ok .. in that case we probably want to pass 1 as a second parameter. from my reading the docs second parameter isnt optional. while it appears that its currently working without a parameter, this might change due to discrepancy with the docs.
There was a problem hiding this comment.
ok .. i talked to the maintainer. he said the docs should be fixed. though he suggested to use http://php.net/manual/en/splobjectstorage.attach.php instead
There was a problem hiding this comment.
yet more information:
[11:53] offsetSet is in fact an alias of attach, and offsetUnset an alias of detach, but it feels more natural to me to use attach/detach
[11:53] or: $objectStorage[$obj] = 2; / unset($objectStorage[$obj]); directly
|
ok closing this one in favor of #200 dont really care of we go with http://php.net/manual/en/splobjectstorage.attach.php instead of offsetSet(). |
…ons (andesk) This PR was squashed before being merged into the master branch (closes symfony#126). Discussion ---------- Adding missing german translation file for validations Commits ------- c4284ca Adding missing german translation file for validations
This PR was squashed before being merged into the master branch (closes symfony#128). Discussion ---------- Check any Composer repository This is an attempt to implement symfony#127 (and would allow symfony#126 to pass). I haven't used the `ComposerRepository` class before, but couldn't see a simple way to consistently find out if a repository knew a particular package name, so it's doing a search then cycling through the results. Commits ------- 0cfad5a Check any Composer repository
not sure about the PhpDumper, but at least the tests still pass with this change.