-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] [Hackday] [2.7] Add a deprecation note about the form_enctype
helper
#12673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrcmorales
commented
Nov 29, 2014
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | yes |
Tests pass? | yes |
Fixed tickets | #12664 |
License | MIT |
Doc PR |
👍 |
Thank you @mrcmorales. |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2014
…`form_enctype` helper (mrcmorales) This PR was merged into the 2.7 branch. Discussion ---------- [Form] [Hackday] [2.7] Add a deprecation note about the `form_enctype` helper | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12664 | License | MIT | Doc PR | Commits ------- 2061a88 issue 12664
Hi there.. I think this changed has introduced a bug. Executing the compiled version of one of fosuserbundle's templates generates a parse error.. template
compiled to <?php
/* FOSUserBundle:Registration:register_content.html.twig */
class __TwigTemplate_b8ccdaee3f5f693a4504c6bdaf93d5496e7461383710c9791f9823624b3a37f3 extends Twig_Template
{
public function __construct(Twig_Environment $env)
{
parent::__construct($env);
$this->parent = false;
$this->blocks = array(
);
}
protected function doDisplay(array $context, array $blocks = array())
{
// line 2
echo "
<form action=\"";
// line 3
echo $this->env->getExtension('routing')->getPath("fos_user_registration_register");
echo "\" ";
echo $this->env->getExtension('form')->renderer->searchAndRenderBlock((isset($context["form"]) ? $context["form"] : $this->getContext($context, "form")), 'enctype') trigger_error('The helper form_enctype(form) is deprecated since version 2.3 and will be removed in 3.0. Use form_start(form) instead.', E_USER_DEPRECATED);
echo " method=\"POST\" class=\"fos_user_registration_register\">
";
// line 4
echo $this->env->getExtension('form')->renderer->searchAndRenderBlock((isset($context["form"]) ? $context["form"] : $this->getContext($context, "form")), 'widget');
echo "
<div>
<input type=\"submit\" value=\"";
// line 6
echo twig_escape_filter($this->env, $this->env->getExtension('translator')->trans("registration.submit", array(), "FOSUserBundle"), "html", null, true);
echo "\" />
</div>
</form>
";
}
public function getTemplateName()
{
return "FOSUserBundle:Registration:register_content.html.twig";
}
public function isTraitable()
{
return false;
}
public function getDebugInfo()
{
return array ( 33 => 6, 28 => 4, 22 => 3, 19 => 2,);
}
} error (line 24)
|
just in case you don't get notified about closed issues ... ping @fabpot |
@dfreudenberger Can you create a new issue? Thanks. |
reverted as it does not work |
This was referenced Dec 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.