[Config] Some tweaks in the component #127
Conversation
| @@ -36,7 +36,7 @@ class ExprBuilder | |||
| /** | |||
| * Mark the expression as being always used. | |||
| * | |||
| * @return Symfony\Component\Config\Definition\Builder\ExprBuilder | |||
There was a problem hiding this comment.
Using the FQCN in the PHPdoc was intended as some IDEs does not autocomplete correctly when the short name is given as the PHPdoc does not refers to the use statement. This would maje the autocompletion painful with these IDE.
There was a problem hiding this comment.
well then again it can also become a problem if the data gets out of sync and any change will lead to potentially unnecessarily long diff's. imho those IDE's need to get fixed.
There was a problem hiding this comment.
This fix is also for consistency...
And to second Lukas, Sf2 is powerful but not meant to fix IDEs !
& everything is not very consistent yet, I have some more modifs in the pipe
|
If this PR eventually ends up in the master repo, the next step is here. Notes:
|
|
I am quite happy with the current state of the "next step". I have asked Johannes to review my code when he has time for that. Note: The commits in the config_refactor branch must really be squashed after review. |
This PR was squashed before being merged into the master branch (closes symfony#128). Discussion ---------- Check any Composer repository This is an attempt to implement symfony#127 (and would allow symfony#126 to pass). I haven't used the `ComposerRepository` class before, but couldn't see a simple way to consistently find out if a repository knew a particular package name, so it's doing a search then cycling through the results. Commits ------- 0cfad5a Check any Composer repository
No description provided.