[3.0] Bumped the minimum php version to 5.5 #12778

GrahamCampbell · 2014-11-30T14:49:46Z

Q	A
Bug fix?	no
New feature?	no
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

This pull request bumps the minimum php version of symfony 3.0 to php 5.5.

This also removes all the hacky workarounds for php 5.3 and 5.4.

TomasVotruba · 2014-11-30T15:16:54Z

composer.json

@@ -16,7 +16,7 @@
        }
    ],
    "require": {
-        "php": ">=5.3.3",
+        "php": ">=5.5.0",


I guess it's the same as >=5.5, isn't it?

Since there is no ~2.2.0 (line bellow), this is inconsistent and should be shorter as well.

@TomasVotruba ~2.2.0 is a different version constraint to ~2.2. They behave totally differently. Keeping the .0 in the all php version constraints seems consistent to me.

timglabisch · 2014-11-30T15:22:16Z

👍

GrahamCampbell · 2014-11-30T21:20:41Z

@fabot I've just removed a load more old hacks. If you want those changes broken up into separate pull requests per component, give me a shout.

nicolas-grekas · 2014-12-01T09:38:40Z

Duplicate of #12522, maybe you can cherry pick my commit and put your additional work on top so we can keep only one PR, yours?

TomasVotruba · 2014-12-01T12:50:42Z

@nicolas-grekas 👍

GrahamCampbell · 2014-12-01T23:55:30Z

@nicolas-grekas Sorry - I missed that pull. It looks like by changes are actually 100% different apart from the travis changes though.

GrahamCampbell · 2014-12-03T19:02:46Z

@fabpot Just rebased.

stof · 2014-12-04T10:02:38Z

Looking at the Travis output, some stuff look broken

timglabisch · 2014-12-04T19:15:19Z

src/Symfony/Component/ClassLoader/Tests/ClassMapGeneratorTest.php

                'TFoo' => __DIR__.'/Fixtures/php5.4/traits.php',
                'CFoo' => __DIR__.'/Fixtures/php5.4/traits.php',
                'Foo\\TBar' => __DIR__.'/Fixtures/php5.4/traits.php',
                'Foo\\IBar' => __DIR__.'/Fixtures/php5.4/traits.php',
                'Foo\\TFooBar' => __DIR__.'/Fixtures/php5.4/traits.php',
                'Foo\\CBar' => __DIR__.'/Fixtures/php5.4/traits.php',
-            ));
-        }
+            )),


"," looks wrong?

Thanks. That's probably one of my errors. I'll go through this again later to check I haven't missed anything.

not a problem IMHO. It's just an additional comma a the and of an array. The same comma as at line 104 of this file

The comma is even required by the Symfony coding standards. It looks a bit weird in the diff. But when looking at the resulting file, everything seems to perfect here.

Yeh, we need trailing commas. I thought it was supposed to be a semicolon looking at the diff, but it's correct as a comma, yeh.

nicolas-grekas · 2014-12-04T20:35:27Z

@GrahamCampbell can you please rebase/cherry-pick on my PR #12522 so I can close it?
The only difference is that I use ~5.5 instead of ~5.5.0, but if you look at hidden comments, you'll see my first version was the same as yours, but @Tobion asked for the removal of the .0 suffix. So you should also.

jderusse · 2014-12-04T20:41:03Z

src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToStringTransformer.php

@@ -66,12 +66,6 @@ public function __construct($inputTimezone = null, $outputTimezone = null, $form

        $this->generateFormat = $this->parseFormat = $format;

-        // The pipe in the parser pattern only works as of PHP 5.3.7
-        // See http://bugs.php.net/54316
-        $this->parseUsingPipe = null === $parseUsingPipe


should be $this->parseUsingPipe = null === $parseUsingPipe ? true : $parseUsingPipe
or even better $this->parseUsingPipe = $parseUsingPipe avec $parseUsingPipe = true par defaut

@jeremy-derusse your second suggestion would change the behavior by not accepting null anymore (and actually changing the implicit support of null in this case because it is a falsy value)

I tought, the default null value was a way for the developper to let symfony decide if the parameter should be true or false. Which only sets it to true when the version of php is greater than 5.3.7
And given this is the last parameter of the list, I did not see why someone will explicitly pass null to this method.

BTW, We could keep this behaviours. It will just like weird in few year when someone will read

function foo($param = null) { if ($param === null) $param = true; }

GrahamCampbell · 2014-12-15T10:32:21Z

Just rebased again, and fixed some issues.

Tobion · 2014-12-15T12:40:46Z

src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php

@@ -211,7 +185,7 @@ public function testSetSaveHandler54()
    /**
     * @expectedException \RuntimeException
     */
-    public function testStartedOutside()
+    public function testStarted()


Thanks for catching this. Forgot to fix this. :)

jderusse · 2014-12-15T12:56:53Z

don't forget https://github.com/symfony/symfony/pull/12778/files#r21334156

nicolas-grekas · 2014-12-27T11:56:04Z

Please see #12778 @GrahamCampbell : I cherry-picked you work on top of mine (updating composer.json and rebasing)

GrahamCampbell · 2014-12-27T12:05:30Z

Moved to #12522.

…amCampbell) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0] Update required PHP to 5.5.9 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13126, #12778 | License | MIT | Doc PR | - This PR upgrades composer.json files to php>=5.5.9 5.5.9 is the lowest version available on Travis and the version shipped with Ubuntu LTS 14.04. We can change the php version later when we'll agree on some other requirement, but currently, this is required to safely merge in master without having some users reporting issues because they have a `dev-master@dev` requirement. Commits ------- 35e0845 [3.0] Removed some old hacks fddcb86 [3.0] Update required PHP to 5.5.9

TomasVotruba reviewed Nov 30, 2014
View reviewed changes

timglabisch reviewed Dec 4, 2014
View reviewed changes

jderusse reviewed Dec 4, 2014
View reviewed changes

GrahamCampbell added 2 commits December 15, 2014 10:06

Bumped the minimum php version to 5.5

86dddd7

Removed some old hacks

a6644d4

Tobion reviewed Dec 15, 2014
View reviewed changes

nicolas-grekas mentioned this pull request Dec 26, 2014

[3.0] Update required PHP to 5.5.9 #12522

Merged

GrahamCampbell closed this Dec 27, 2014

GrahamCampbell deleted the 3.0-php-version branch December 27, 2014 12:05

xabbuh mentioned this pull request Jan 4, 2015

bump Symfony requirements to PHP 5.5 symfony/symfony-docs#4753

Merged

Uh oh!

[3.0] Bumped the minimum php version to 5.5 #12778

[3.0] Bumped the minimum php version to 5.5 #12778

Uh oh!

Conversation

GrahamCampbell commented Nov 30, 2014

This pull request bumps the minimum php version of symfony 3.0 to php 5.5.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timglabisch commented Nov 30, 2014

Uh oh!

GrahamCampbell commented Nov 30, 2014

Uh oh!

nicolas-grekas commented Dec 1, 2014

Uh oh!

TomasVotruba commented Dec 1, 2014

Uh oh!

GrahamCampbell commented Dec 1, 2014

Uh oh!

GrahamCampbell commented Dec 3, 2014

Uh oh!

stof commented Dec 4, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Dec 4, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GrahamCampbell commented Dec 15, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jderusse commented Dec 15, 2014

Uh oh!

nicolas-grekas commented Dec 27, 2014

Uh oh!

GrahamCampbell commented Dec 27, 2014

Uh oh!

Uh oh!