[2.5] CS Fixes And Removed Unused Imports #12856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -653,7 +654,9 @@ protected function getSelectSecurityIdentityIdSql(SecurityIdentityInterface $sid | |||
| * Constructs the SQL to delete a security identity. | |||
| * | |||
| * @param SecurityIdentityInterface $sid | |||
| * | |||
| * @throws \InvalidArgumentException | |||
There was a problem hiding this comment.
I guess you could move @throws below @return.
There was a problem hiding this comment.
No, the standard seems to be to have param first, then throws, then return.
Symfony itself, is a tad inconsistent with this tbh.
|
Thank you @GrahamCampbell. |
fabpot
added a commit
that referenced
this pull request
Dec 5, 2014
This PR was merged into the 2.5 branch. Discussion ---------- [2.5] CS Fixes And Removed Unused Imports | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A ##### This pull request fixes some cs issues in symfony 2.5. I've applied the same set of fixes that I did to the 2.3 branch. There are far fewer fixes than there were for 2.3, so I've just done them all at once. Commits ------- ed4fb54 CS fixes
fabpot
added a commit
that referenced
this pull request
Dec 7, 2014
…ell) This PR was squashed before being merged into the 2.6 branch (closes #12872). Discussion ---------- [2.6] CS Fixes And Removed An Unused Import | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A ##### This pull request fixes some cs issues in symfony 2.6. This is the sequel to #12856. Commits ------- 2f10a0a [2.6] CS Fixes And Removed An Unused Import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes some cs issues in symfony 2.5.
I've applied the same set of fixes that I did to the 2.3 branch.
There are far fewer fixes than there were for 2.3, so I've just done them all at once.