Skip to content

Adding note about the PdoSessionHandler BC break #12890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2014

Conversation

weaverryan
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12833
License MIT
Doc PR symfony/symfony-docs#4609

Hi guys!

This adds an UPGRADE note about the PdoSessionHandler BC break in 2.6. I also added a section on top, which might be more controversial that highlights the BC breaks. That's because this document is long, and much of it is telling you about deprecated features. But what I first want to know is - what will break?

I'm also still interested in maybe adding the old PdoSessionHandler to 2.6 and allowing you to use that one to keep BC (still a BC break, but you could choose to use the old one).

Thanks!

@fabpot
Copy link
Member

fabpot commented Dec 8, 2014

Thank you @weaverryan.

@fabpot fabpot merged commit adfdad9 into symfony:2.6 Dec 8, 2014
fabpot added a commit that referenced this pull request Dec 8, 2014
…ryan)

This PR was merged into the 2.6 branch.

Discussion
----------

Adding note about the PdoSessionHandler BC break

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12833
| License       | MIT
| Doc PR        | symfony/symfony-docs#4609

Hi guys!

This adds an UPGRADE note about the PdoSessionHandler BC break in 2.6. I also added a section on top, which might be more controversial that highlights the BC breaks. That's because this document is long, and much of it is telling you about deprecated features. But what I first want to know is - what will break?

I'm also still interested in maybe adding the old PdoSessionHandler to 2.6 and allowing you to use that one to keep BC (still a BC break, but you could choose to use the old one).

Thanks!

Commits
-------

adfdad9 Adding note about known BC issues
42950e9 Adding note about the PdoSessionHandler BC break
@weaverryan weaverryan deleted the pdo-session-upgrade branch December 8, 2014 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants