-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle][Template name] avoid error message for the shortcut n... #12894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aitboudad
commented
Dec 8, 2014
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Fixed tickets | #12249, #12254 |
Tests pass? | yes |
License | MIT |
Thank you @aitboudad. |
…he shortcut n... (aitboudad) This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle][Template name] avoid error message for the shortcut n... | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #12249, #12254 | Tests pass? | yes | License | MIT Commits ------- 055129c [FrameworkBundle][Template name] avoid error message for the shortcut notation.
@fabpot there is actually a BC break in this change:
what would be your preferred way to fix this ? |
Note that AsseticBundle is affected by this break for instance (this is how I found it) |
I think option 2 would be better. |
Actually, the option 2 is not good, because some of the parent references cannot be represented with a FrameworkBundle reference (it forces the logical name to have template.format.engine while the component reference does not have any restriction).
Btw, the |