Skip to content

[WebProfiler] Tweaked ajax requests toolbar css reset #12899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WebProfiler] Tweaked ajax requests toolbar css reset #12899

wants to merge 1 commit into from

Conversation

1ed
Copy link
Contributor

@1ed 1ed commented Dec 8, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12139 (not sure)
License MIT
Doc PR -

Before:
screenshot from 2014-12-08 14 52 42

After:
screenshot from 2014-12-08 15 14 35

@1ed 1ed mentioned this pull request Dec 8, 2014
Closed
@javiereguiluz
Copy link
Member

👍 @1ed thanks for fixing this annoying problem!

By the way, if I recall it correctly, /_wdt/* Ajax calls shouldn't appear in that table (and indeed, in the first versions of the toolbar they didn't appear). If this is true, we should create a separate issue to fix that issue.

@1ed
Copy link
Contributor Author

1ed commented Dec 8, 2014

Sorry this should go into 2.6 instead of 2.7.

@1ed
Copy link
Contributor Author

1ed commented Dec 8, 2014

@javiereguiluz there is an issue for that already 12122

@fabpot
Copy link
Member

fabpot commented Dec 11, 2014

Thank you @1ed.

fabpot added a commit that referenced this pull request Dec 11, 2014
@fabpot
bug #12899 [WebProfiler] Tweaked ajax requests toolbar css reset (1ed)
4d3d197 
This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes #12899).

Discussion
----------

[WebProfiler] Tweaked ajax requests toolbar css reset

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12139 (not sure)
| License       | MIT
| Doc PR        | -

Before:
![screenshot from 2014-12-08 14 52 42](https://cloud.githubusercontent.com/assets/162986/5340221/7b3f1716-7eea-11e4-81c7-f46768736289.png)

After:
![screenshot from 2014-12-08 15 14 35](https://cloud.githubusercontent.com/assets/162986/5340443/fbfb3d1a-7eec-11e4-8960-9990937a49a1.png)

Commits
-------

16a51e7 [WebProfiler] Tweaked ajax requests toolbar css reset
@fabpot fabpot closed this Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1ed @javiereguiluz @fabpot