Skip to content

[TwigBundle] avoid risky tests #12903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2014
Merged

[TwigBundle] avoid risky tests #12903

merged 1 commit into from
Dec 11, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 8, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12646
License MIT
Doc PR

@stof
Copy link
Member

stof commented Dec 9, 2014

@fabpot it would be good to have fabbot setting the context key when setting its status (and stopping to build a combined status given that Github finally displays the combined status directly).

@stof
Copy link
Member

stof commented Dec 9, 2014

👍

@fabpot
Copy link
Member

fabpot commented Dec 11, 2014

Thank you @xabbuh.

@fabpot fabpot merged commit e7b0b89 into symfony:2.6 Dec 11, 2014
fabpot added a commit that referenced this pull request Dec 11, 2014
This PR was merged into the 2.6 branch.

Discussion
----------

[TwigBundle] avoid risky tests

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12646
| License       | MIT
| Doc PR        |

Commits
-------

e7b0b89 avoid risky tests
@xabbuh xabbuh deleted the issue-12646 branch December 11, 2014 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants