Skip to content

[HttpKernel] fix DumpDataCollectorTest after CS changes #12904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 8, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Modify the expected line value which was affected by the move of the
__LINE__ constant in #12872 to make tests pass again.

Modify the expected line value which was affected by the move of the
`__LINE__` constant in symfony#12872 to make tests pass again.
@nicolas-grekas
Copy link
Member

👍

1 similar comment
@stof
Copy link
Member

stof commented Dec 9, 2014

👍

@fabpot
Copy link
Member

fabpot commented Dec 12, 2014

Thank you @xabbuh.

@fabpot fabpot merged commit 1917b70 into symfony:2.6 Dec 12, 2014
fabpot added a commit that referenced this pull request Dec 12, 2014
…(xabbuh)

This PR was merged into the 2.6 branch.

Discussion
----------

[HttpKernel] fix DumpDataCollectorTest after CS changes

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Modify the expected line value which was affected by the move of the
`__LINE__` constant in #12872 to make tests pass again.

Commits
-------

1917b70 fix DumpDataCollectorTest after CS changes
@xabbuh xabbuh deleted the fix-data-collector-tests branch December 12, 2014 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants