[WebProfilerBundle] Avoid missing method when using __invoke on a controller #12958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thewilkybarkid thanks for your PR! I love these quick wins! By the way, your message ends abruptly, so it's been probably cut unintentionally: "This PR changes it to only include the method section/double dots if the method name is included. This does mean that there is no link included... (so either the )" |
|
@javiereguiluz Fixed now. Got to that point, fixed the code, didn't fix the text. 😃 |
|
👍 |
|
Thank you @thewilkybarkid. |
fabpot
added a commit
that referenced
this pull request
Dec 12, 2014
…voke on a controller (thewilkybarkid) This PR was merged into the 2.6 branch. Discussion ---------- [WebProfilerBundle] Avoid missing method when using __invoke on a controller | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | 2.6 added support for using `__invoke` on controllers, but the profiler toolbar still expects a method name, leading to:  This PR changes it to only include the method section/double dots if the method name is included (and the `link` is moved to the class name). Commits ------- fb87558 Avoid missing method when using __invoke
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…ng __invoke on a controller (thewilkybarkid) This PR was merged into the 2.6 branch. Discussion ---------- [WebProfilerBundle] Avoid missing method when using __invoke on a controller | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | 2.6 added support for using `__invoke` on controllers, but the profiler toolbar still expects a method name, leading to:  This PR changes it to only include the method section/double dots if the method name is included (and the `link` is moved to the class name). Commits ------- fb87558 Avoid missing method when using __invoke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.6 added support for using
__invokeon controllers, but the profiler toolbar still expects a method name, leading to:This PR changes it to only include the method section/double dots if the method name is included (and the
linkis moved to the class name).