fix #10054 - form data collector with dynamic fields #13027

zulus · 2014-12-18T12:56:38Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#10054
License	MIT
Doc PR	-

This simple patch will fix webprofiler bug with collection field.

| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#10054 | License | MIT | Doc PR | -

fabpot · 2014-12-21T16:14:17Z

Just tested with the steps described here: #11474 (comment) and I confirm that this fixes the issue.

fabpot · 2014-12-21T16:15:14Z

Note to myself: this should be merged in 2.5.

fabpot · 2014-12-21T16:17:56Z

@zulus Can you add a unit test to ensure that we don't have a regression in the future? Thanks.

zulus · 2014-12-21T21:21:55Z

@fabpot Off course. I also can close this pull request and prepare for 2.5 with tests.

sergionegri · 2014-12-27T14:14:46Z

I think I have a similar issue with Symfony 2.6.1. I created a form (which works perfectly) but when I call the profiler I get:

Key "type" for array with keys "id, name, view_vars, children" does not exist in @WebProfiler/Collector/form.html.twig at line 423

Will the fix also be merged in 2.6.1?

The only thing I don't have the allow_add enabled :/

fabpot · 2014-12-29T08:52:04Z

Thank you @zulus.

This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes #13027). Discussion ---------- fix #10054 - form data collector with dynamic fields | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10054 | License | MIT | Doc PR | - This simple patch will fix webprofiler bug with collection field. Commits ------- cffb64f fix #10054 - form data collector with dynamic fields

fabpot · 2014-12-29T08:52:28Z

@zulus I've merged your PR in the 2.5 branch. Can you open a new PR on 2.5 to add some unit tests? Thanks.

wouterj · 2014-12-29T09:28:24Z

Awesome, thank you very much @zulus for fixing this issue!

fabpot · 2014-12-29T09:45:38Z

@zulus Can you have a look at the tests; they are actually broken because of this PR:

phpunit src/Symfony/Component/Form/Tests/Extension/DataCollector/FormDataCollectorTest.php
PHPUnit 4.3.5 by Sebastian Bergmann.

Configuration read from phpunit.xml.dist

........E

Time: 146 ms, Memory: 5.00Mb

There was 1 error:

1) Symfony\Component\Form\Tests\Extension\DataCollector\FormDataCollectorTest::testCollectSubmittedDataCountsErrors
array_replace(): Argument #2 is not an array

src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php:106
src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php:143
src/Symfony/Component/Form/Tests/Extension/DataCollector/FormDataCollectorTest.php:514

| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | -

zulus · 2014-12-29T13:11:03Z

@fabpot PR #13151 fixes regression

xabbuh · 2014-12-29T21:14:45Z

@sergionegri Has your issue been fixed with the latest 2.5-dev version? Or can you confirm that #13155 is the same as your issue?

This PR was merged into the 2.5 branch. Discussion ---------- fix regression in form tests after pr #13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 1121064 fix regression in form tests after pr #13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | -

* 2.5: Updated generateSql tool Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger fix regression in form tests after pr #13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix #10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port Update the note about origins of the CssSelector component. Use the correct cssselect library name in docblocks. [DomCrawler] fixed bug #12143 Conflicts: src/Symfony/Bundle/FrameworkBundle/Templating/GlobalVariables.php src/Symfony/Component/Serializer/Normalizer/DenormalizableInterface.php

* 2.6: (21 commits) Updated generateSql tool Fix grammar Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger fix regression in form tests after pr #13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix #10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port Update the note about origins of the CssSelector component. Use the correct cssselect library name in docblocks. Fix wrong DateTransformer timezone param for non-UTC configuration. #12808 [Form] Add further timezone tests for date type ... Conflicts: src/Symfony/Component/Locale/Locale.php src/Symfony/Component/Locale/composer.json

* 2.7: (26 commits) Updated generateSql tool Fix grammar Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger Updated the SQL data generated from the generateSql tool Updated generateSql tool fix regression in form tests after pr #13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - [FrameworkBundle] added a test router for the buil-in web server Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix #10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port [2.7] Allow 3.0 requirements ...

sergionegri · 2014-12-30T10:50:03Z

@xabbuh I'm new to github and the way to properly interact with the community, so please excuse me in advance if my approach is not right. I'm running v2.7.0 now and the problem persists. Should it be fixed? I see the pull requests for 2.7 also, but don't know if they are implemented already or not.

xabbuh · 2014-12-30T10:59:02Z

@sergionegri There was no new release since the issue has been fixed. This mean that you would at least have to use the latest development version to check. Though I think that this won't solve your problem since your error message is the same as the one in #13155. Fortunately, there is already a proposed fix for this (see #13166) which should resolve your issue.

wouterj · 2014-12-30T11:02:02Z

Btw, basing on 2.7 is not a very good decision. It's still in early-development. You should try out 2.6.

sergionegri · 2014-12-30T11:04:23Z

I'll wait for the next update then. I was on 2.6.1 but running "composer update" it upgraded to 2.7. How can I tell it to upgrade to any 2.6.X but not 2.7.X?

wouterj · 2014-12-30T11:12:43Z

Make sure to have "minimum-stability": "stable" in your composer.json

sergionegri · 2014-12-30T11:24:41Z

Sorry, I confirm I still run 2.6.1. Running the last "composer update" I saw a "(v2.7.0)" and assumed it was Symfony, but actually it was the symfony/monolog-bundle. I also checked and the "stable" option should be the default one, so I should be ok. As soon as it gets fixed in a stable version I'll let you know if it gets fixed.

zulus · 2014-12-30T11:48:41Z

@sergionegri If you want test latest 2.6 snapshot, replace:

"symfony/symfony" : "2.6.*"

with

"symfony/symfony" : "2.6.*@dev"

in your composer.json and run composer.phar update symfony/symfony

* 2.5: Updated generateSql tool Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger fix regression in form tests after pr symfony#13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix symfony#10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port Update the note about origins of the CssSelector component. Use the correct cssselect library name in docblocks. [DomCrawler] fixed bug symfony#12143 Conflicts: src/Symfony/Bundle/FrameworkBundle/Templating/GlobalVariables.php src/Symfony/Component/Serializer/Normalizer/DenormalizableInterface.php

* 2.6: (21 commits) Updated generateSql tool Fix grammar Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger fix regression in form tests after pr symfony#13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix symfony#10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port Update the note about origins of the CssSelector component. Use the correct cssselect library name in docblocks. Fix wrong DateTransformer timezone param for non-UTC configuration. symfony#12808 [Form] Add further timezone tests for date type ... Conflicts: src/Symfony/Component/Locale/Locale.php src/Symfony/Component/Locale/composer.json

* 2.7: (26 commits) Updated generateSql tool Fix grammar Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger Updated the SQL data generated from the generateSql tool Updated generateSql tool fix regression in form tests after pr symfony#13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - [FrameworkBundle] added a test router for the buil-in web server Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix symfony#10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port [2.7] Allow 3.0 requirements ...

* 2.5: Updated generateSql tool Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger fix regression in form tests after pr symfony#13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix symfony#10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port Update the note about origins of the CssSelector component. Use the correct cssselect library name in docblocks. [DomCrawler] fixed bug symfony#12143 Conflicts: src/Symfony/Bundle/FrameworkBundle/Templating/GlobalVariables.php src/Symfony/Component/Serializer/Normalizer/DenormalizableInterface.php

* 2.6: (21 commits) Updated generateSql tool Fix grammar Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger fix regression in form tests after pr symfony#13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix symfony#10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port Update the note about origins of the CssSelector component. Use the correct cssselect library name in docblocks. Fix wrong DateTransformer timezone param for non-UTC configuration. symfony#12808 [Form] Add further timezone tests for date type ... Conflicts: src/Symfony/Component/Locale/Locale.php src/Symfony/Component/Locale/composer.json

* 2.7: (26 commits) Updated generateSql tool Fix grammar Fix the implementation of deprecated Locale classes Fix phpdoc and coding standards Replace usages of the deprecated TypeTestCase by the new one Remove usages of deprecated constants Update functional tests to use the PSR NullLogger Updated the SQL data generated from the generateSql tool Updated generateSql tool fix regression in form tests after pr symfony#13027 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - [FrameworkBundle] added a test router for the buil-in web server Make fabbot happy Clean up testing No global state for isolated tests and other fixes No global state for isolated tests and other fixes fix symfony#10054 - form data collector with dynamic fields [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment [Debug] fix checkip6 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port [2.7] Allow 3.0 requirements ...

fix symfony#10054 - form data collector with dynamic fields

de570d9

| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#10054 | License | MIT | Doc PR | -

zulus force-pushed the bug_10054 branch from ee1ca78 to de570d9 Compare December 18, 2014 13:08

fabpot added the Form label Dec 18, 2014

fabpot mentioned this pull request Dec 21, 2014

[Form][WebProfiler] Fixed issue#10054 : cannot report form data when "allow_add" is true in a field #12889

Closed

fabpot closed this Dec 29, 2014

xabbuh mentioned this pull request Dec 29, 2014

Error on Form Web Profiler on fields added to the form #13155

Closed

zulus deleted the bug_10054 branch December 30, 2014 11:08

Uh oh!

fix #10054 - form data collector with dynamic fields #13027

fix #10054 - form data collector with dynamic fields #13027

Uh oh!

Conversation

zulus commented Dec 18, 2014

Uh oh!

fabpot commented Dec 21, 2014

Uh oh!

fabpot commented Dec 21, 2014

Uh oh!

fabpot commented Dec 21, 2014

Uh oh!

zulus commented Dec 21, 2014

Uh oh!

sergionegri commented Dec 27, 2014

Uh oh!

fabpot commented Dec 29, 2014

Uh oh!

fabpot commented Dec 29, 2014

Uh oh!

wouterj commented Dec 29, 2014

Uh oh!

fabpot commented Dec 29, 2014

Uh oh!

zulus commented Dec 29, 2014

Uh oh!

xabbuh commented Dec 29, 2014

Uh oh!

sergionegri commented Dec 30, 2014

Uh oh!

xabbuh commented Dec 30, 2014

Uh oh!

wouterj commented Dec 30, 2014

Uh oh!

sergionegri commented Dec 30, 2014

Uh oh!

wouterj commented Dec 30, 2014

Uh oh!

sergionegri commented Dec 30, 2014

Uh oh!

zulus commented Dec 30, 2014

Uh oh!

Uh oh!