[2.7] adds deprecation notices. #13060

hhamon · 2014-12-21T12:22:51Z

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#12608, #12672, #12675 #12684, #12686
License	MIT
Doc PR	~

hhamon · 2014-12-21T15:45:40Z

src/Symfony/Component/Validator/Constraints/IsbnValidator.php

-                $constraint->type = 'isbn13';
+        if (null == $this->type) {
+            if ($this->isbn10 && !$this->isbn13) {
+                trigger_error('The "isbn10" option of the Isbn constraint is deprecated since version 2.5 and will be removed in 3.0. Use the "type" option instead.', E_USER_DEPRECATED);


IMO this should go into the Isbn class.

nicolas-grekas · 2014-12-23T10:49:30Z

Rebase needed.
If you want to add notices for deprecated constants in this PR also, here is how:
#12968 (diff)

(e.g. Symfony\Component\Debug\ErrorHandler::TYPE_DEPRECATION)

hhamon · 2014-12-23T12:30:53Z

This PR has been rebased. Let's see what Travis says now.

hhamon · 2014-12-26T10:15:25Z

Tests are green from 5.3.3 to 5.6 but the matrix still reports failures on components low and high.

hhamon · 2014-12-26T10:24:55Z

It seems failing tests are due to PHPUnit.

hhamon · 2014-12-26T15:23:46Z

Yeah test suite is finally green! Thanks @nicolas-grekas. Ping @fabpot

hhamon · 2014-12-26T16:20:52Z

Even though tests are passing, this PR is still a WIP as some deprecation messages still need to be normalized.

stof · 2015-01-04T11:45:39Z

src/Symfony/Component/Form/Util/VirtualFormAwareIterator.php

+         * The {@link Symfony\Component\Form\Util\InheritDataAwareIterator::__construct} method
+         * forces this argument to false.
+         */
+        if ($triggerDeprecationNotice) {


instead of adding an extra argument, it would be more reliable to use get_class($this) === __CLASS__ given that our use case for avoiding the trigger is for the child class.

hhamon · 2015-01-04T12:43:19Z

src/Symfony/Bundle/TwigBundle/Extension/ActionsExtension.php

@@ -20,7 +20,7 @@
 *
 * @author Fabien Potencier <fabien@symfony.com>
 *
- * @deprecated Deprecated in 2.2, to be removed in 3.0.
+ * @deprecated since version 2.2, to be removed in 3.0.


@stof @fabpot is the class still considered deprecated or only the construct method arguments?

Looks like it is as per b957f44. The strange thing is the introduced deprecation notice in the construct method saying passing a ContainerInterface instance is deprecated since version 2.7 and will be removed in 3.0. The whole class is already deprecated and will be removed in 3.0, which is confusing.

The whole class was deprecated in 2.2. I changed the constructor argument in 2.7. But anyway, nobody should use this class and it will be removed in 3.0. See #13233

…revent breaking third party projects implementing them.

…FormAwareIterator class.

nicolas-grekas · 2015-01-05T19:32:21Z

I tested this PR locally after rebasing it on latest 2.7, tests are green.
There is one minor conflict in src/Symfony/Component/Validator/Mapping/TraversalStrategy.php that I resolved like this:

     * @deprecated since version 2.5, to be removed in 3.0.
     *             This constant was added for backward compatibility only.
     * @internal

👍 from me. There are places where we'll need to remove/update some deprecation triggers and adding all of them like done here will allow us to see where. I'll enhance the deprecation summary once this gets merged so we can start by the most complaining triggers.

fabpot · 2015-01-05T20:51:54Z

Thank you @hhamon.

@stof

This PR was merged into the 2.7 branch. Discussion ---------- [2.7] adds deprecation notices. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12608, #12672, #12675 #12684, #12686 | License | MIT | Doc PR | ~ Commits ------- f9fbb4f Fixes more deprecation notices as per @stof review. fd47c07 Fixed some deprecations according to @stof feedbacks. 2a3e7d2 Normalizes deprecation notice messages. 738b9be [Validator] fixes UuidValidator deprecated class namespace. e608ba6 [Form] adds more deprecation notices. cd9617a [Validator] adds more deprecation notices. a7f841e [Form] Adds a way to trigger deprecation notice on demand for VirtualFormAwareIterator class. 97efd2c Fixes more deprecation notices. fd9c7bb Normalized @deprecated annotations. 39cfd47 Removed deprecation notices from test files. 2a9749d Fixes deprecation notices. 6f57b7b Reverted trigger_error() function calls on deprecated interfaces to prevent breaking third party projects implementing them. 86b9f6b Adds deprecation notices for structures to be removed in 3.0.

hhamon · 2015-01-05T22:38:14Z

Great to see that work merged. Let's see now how to handle all deprecations.

hhamon force-pushed the deprecation-notices branch 5 times, most recently from ce0930c to 1359afb Compare December 21, 2014 15:26

hhamon changed the title ~~[2.7] [WIP] adds deprecation notices.~~ [2.7] adds deprecation notices. Dec 21, 2014

hhamon force-pushed the deprecation-notices branch from 1359afb to 940da08 Compare December 21, 2014 15:43

hhamon reviewed Dec 21, 2014
View reviewed changes

hhamon force-pushed the deprecation-notices branch 2 times, most recently from ef08363 to 2e35356 Compare December 23, 2014 12:30

hhamon force-pushed the deprecation-notices branch 4 times, most recently from 9f65033 to baa9163 Compare December 26, 2014 09:53

hhamon force-pushed the deprecation-notices branch 4 times, most recently from 5320819 to d6f28ae Compare December 26, 2014 15:15

hhamon mentioned this pull request Dec 26, 2014

Consider removing the new trigger_error deprecation warnings #12973

Closed

hhamon force-pushed the deprecation-notices branch 2 times, most recently from 0d623e4 to 616de96 Compare December 26, 2014 16:01

hhamon changed the title ~~[2.7] adds deprecation notices.~~ [2.7] [WIP] adds deprecation notices. Dec 26, 2014

stof reviewed Jan 4, 2015
View reviewed changes

hhamon force-pushed the deprecation-notices branch from 2806171 to cd96ff9 Compare January 4, 2015 12:42

hhamon reviewed Jan 4, 2015
View reviewed changes

Hugo Hamon added 13 commits January 5, 2015 15:57

Adds deprecation notices for structures to be removed in 3.0.

86b9f6b

Reverted trigger_error() function calls on deprecated interfaces to p…

6f57b7b

…revent breaking third party projects implementing them.

Fixes deprecation notices.

2a9749d

Removed deprecation notices from test files.

39cfd47

Normalized @deprecated annotations.

fd9c7bb

Fixes more deprecation notices.

97efd2c

[Form] Adds a way to trigger deprecation notice on demand for Virtual…

a7f841e

…FormAwareIterator class.

[Validator] adds more deprecation notices.

cd9617a

[Form] adds more deprecation notices.

e608ba6

[Validator] fixes UuidValidator deprecated class namespace.

738b9be

Normalizes deprecation notice messages.

2a3e7d2

Fixed some deprecations according to @stof feedbacks.

fd47c07

Fixes more deprecation notices as per @stof review.

f9fbb4f

hhamon force-pushed the deprecation-notices branch from cd96ff9 to f9fbb4f Compare January 5, 2015 15:02

fabpot merged commit f9fbb4f into symfony:2.7 Jan 5, 2015

nicolas-grekas mentioned this pull request Jan 6, 2015

[Form] Deprecated setDefaultOptions() in favor of configureOptions() #12891

Merged

stof mentioned this pull request Jan 8, 2015

[HttpFoundation] remove deprecated : FlashBag don't implement anymore IteratorAggregate #13258

Closed

tgalopin mentioned this pull request Apr 4, 2016

Add action to edit any type of file liip/RMT#106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.7] adds deprecation notices. #13060

[2.7] adds deprecation notices. #13060

hhamon commented Dec 21, 2014

hhamon Dec 21, 2014

nicolas-grekas commented Dec 23, 2014

hhamon commented Dec 23, 2014

hhamon commented Dec 26, 2014

hhamon commented Dec 26, 2014

hhamon commented Dec 26, 2014

hhamon commented Dec 26, 2014

stof Jan 4, 2015

hhamon Jan 4, 2015

hhamon Jan 4, 2015

fabpot Jan 4, 2015

hhamon Jan 4, 2015

nicolas-grekas commented Jan 5, 2015

fabpot commented Jan 5, 2015

hhamon commented Jan 5, 2015

[2.7] adds deprecation notices. #13060

[2.7] adds deprecation notices. #13060

Conversation

hhamon commented Dec 21, 2014

hhamon Dec 21, 2014

Choose a reason for hiding this comment

nicolas-grekas commented Dec 23, 2014

hhamon commented Dec 23, 2014

hhamon commented Dec 26, 2014

hhamon commented Dec 26, 2014

hhamon commented Dec 26, 2014

hhamon commented Dec 26, 2014

stof Jan 4, 2015

Choose a reason for hiding this comment

hhamon Jan 4, 2015

Choose a reason for hiding this comment

hhamon Jan 4, 2015

Choose a reason for hiding this comment

fabpot Jan 4, 2015

Choose a reason for hiding this comment

hhamon Jan 4, 2015

Choose a reason for hiding this comment

nicolas-grekas commented Jan 5, 2015

fabpot commented Jan 5, 2015

hhamon commented Jan 5, 2015