[WebProfilerBundle] Improved page for logs #13324
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 nice Maybe use the new |
|
👍 |
|
👍 |
| {{ log.priorityName }} | ||
| {%- endif -%} | ||
| </td> | ||
| <td>{{ log.channel is defined ? log.channel }}</td> |
There was a problem hiding this comment.
What about removing the column when we don't have information about the channel?
|
looks good but needs a lot of space. i would like to see stats about rendering performance on large logs. |
|
Can you rebase this one? |
|
@fabpot Rebased. |
|
Thank you @hason. |
fabpot
added a commit
that referenced
this pull request
May 17, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #13324). Discussion ---------- [WebProfilerBundle] Improved page for logs | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - *Before*  *After*  Commits ------- 5fdc650 [WebProfilerBundle] Improved page for logs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After