[FrameworkBundle][config] allow multiple fallback locales. #13376
Conversation
aitboudad
commented
Jan 12, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #13373 |
| Doc PR | symfony/symfony-docs#4834 |
| Tests pass? | yes |
| License | MIT |
6d7b776 to
7e16f49
Compare
|
👍 Not sure if this is considered bug fix or new feature though. We’ll see. Update to the docs also should be made. |
|
I would consider it as a bug fix. 👍 |
|
Fyi, a PR to the docs is submitted |
|
The XML schema needs to be updated to support multiple fallbacks too |
7e16f49 to
f962355
Compare
|
@stof done |
|
While we are at it, what about allowing |
|
We should indeed have |
f962355 to
cc3bbc6
Compare
|
done |
| <framework:fallback>fr</framework:fallback> | ||
| </framework:translator> | ||
| </framework:config> | ||
| </container> |
There was a problem hiding this comment.
This file does not seem to be used anywhere in the tests. Have you forgot to commit them? Tests should also be done for other formats like YAML.
cc3bbc6 to
1251f0e
Compare
|
@fabpot I added the missing files. |
|
Thank you @aitboudad. |
… (aitboudad) This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle][config] allow multiple fallback locales. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #13373 | Doc PR | symfony/symfony-docs#4834 | Tests pass? | yes | License | MIT Commits ------- 1251f0e [FrameworkBundle][config] allow multiple fallback locales.
| @@ -206,6 +206,14 @@ public function testTranslator() | |||
| $this->assertEquals(array('fr'), $calls[0][1][0]); | |||
| } | |||
|
|
|||
| public function testTranslatorMultipleFullback() | |||
There was a problem hiding this comment.
pondering why it's 'Fullback' and not 'Fallback'
There was a problem hiding this comment.
Would you mind to submit a PR fixing this typo? :)
This PR was merged into the 2.3 branch. Discussion ---------- [translator] use the new fallbacks option. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | symfony/symfony#13376 Commits ------- 92194f2 [config][translator] use the new fallbacks option.