This is now making it impossible to debug the whole translations

@stof What do you mean with "the whole translations"? Before the change a bundle name was already mandatory.

ping @stof I'm not sure what to do. Could you explain your last comment, please?

@xelaris, stof means if we put the defaults value to app/Resources folder, there is no way to debug all translations available in the app.

How was it possible before? Since the bundle argument of the debug:translation command was defined as InputArgument::REQUIRED it was not possible to call the command without a bundle name. So I can't see the limitation in making it optional and falling back to app/Resources. Maybe I overlook something?

IMO if we want to set a default value for this command I think it should be the whole translations.

Ok, I got the point. We could keep the bundle argument required, but still enable to provide a path besides a bundle name. But this in turn would be inconsistent with the translation:update command where the argument falls back to app/Resources and I think it is not very intuitive. On the other hand I agree, it would be nice to debug the whole applications translations, and at first glance the most intuitive way to do this would to call the command without a bundle name.
However following the defined best practice, the most common way is to keep all app translations in app/Resources. And hence the main use case would to call the command to debug translations in app/Resources. It would may be nice to make this call the shortest one. IMO Debugging translations of all bundles would be a less common use case. What about an --all option, which could be passed, if someone would debug the whole application?

--all sound good to me

@xelaris any news ?

I think an --all option is out of scope of this PR, since it adds a new feature. I can start working on it, but don't know when I get to it. So what about merging this PR (if everything else is fine) and making it possible to debug all translations in a subsequent PR?

I'm ok, then can we also move the defaults value(app/Resources folder) feature ?

@xelaris TranslationUpdateCommand use defaults to app/Resources folder, forget my previous comment :)

👍 ping @fabpot

@xelaris can apply the below patch and rebase your branch:

@@ -116,7 +116,9 @@ EOF

         // Extract used messages
         $extractedCatalogue = new MessageCatalogue($locale);
-        $this->getContainer()->get('translation.extractor')->extract($rootPath.'/Resources/views', $extractedCatalogue);
+        if (is_dir($translationsPath)) {
+            $this->getContainer()->get('translation.extractor')->extract($translationsPath, $extractedCatalogue);
+        }

         // Load defined messages
         $currentCatalogue = new MessageCatalogue($locale);

once you made the change I'll merge :)

@aitboudad The branch is rebased and I added the is_dir check from the patch, but kept $rootPath.'/Resources/views', since $translationsPath contains $rootPath.'/Resources/translations'.

@xelaris ok nice !

Thank you @xelaris.

@xelaris can you open an issue for --all option, if someone wants to work on it?

Thanks for merging @aitboudad, an issue for the --all option is created.