Fix profiler throwing javascript errors on IE8 & IE9 #13447 #13634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, false); | ||
| /* check for older browsers */ | ||
| if (!window.addEventListener) { | ||
| this.attachEvent("readystatechange", function () { |
There was a problem hiding this comment.
It's onreadystatechange if I'm not wrong?
I'd also deduplicate the closure by putting it in a variable
There was a problem hiding this comment.
It can be nice to add a comment like that to help people to handerstand this part of code.
// Fix ie8&9, does not have XMLHttpRequest.addEventListener method.
// @see https://developer.mozilla.org/fr/docs/Web/API/Element.addEventListener#Internet_Explorer| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR |
| }; | ||
|
|
||
| /* check for older browsers */ | ||
| if (!window.addEventListener) { |
There was a problem hiding this comment.
you should use this.addEventListener here as this is what you use just after
| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR |
|
There is also 2 addEventListener calls in |
|
Closing in favor of #13636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.