[HttpKernel] Throw a LogicException when kernel.exception does not lead to a Response #13780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Feb 24, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| } | ||
| } elseif (!$original || $isCritical) { | ||
| error_log($message); |
There was a problem hiding this comment.
Useless once #13767 is merged since the importants exceptions will be thrown now, and we have an exception handler that is suited for the prod env
a8d2cbb to
e821984
Compare
| @@ -229,7 +229,7 @@ private function handleException(\Exception $e, $request, $type) | |||
| if (!$event->hasResponse()) { | |||
| $this->finishRequest($request, $type); | |||
|
|
|||
| throw $e; | |||
| throw new \LogicException('Handling "kernel.exception" events should led to a Response', 0, $e); | |||
There was a problem hiding this comment.
This is the main goal of this PR
There was a problem hiding this comment.
'Handling of the "kernel.exception" event should lead to a Response' would be better.
Or perhaps 'No "kernel.exception" event listener created a Response'?
There was a problem hiding this comment.
I reworded the message to No listeners of the "kernel.exception" event set a Response
e821984 to
cb63767
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2015
…ion does not lead to a Response (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] Throw a LogicException when kernel.exception does not lead to a Response | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 22f4807 [HttpKernel] Throw a LogicException when kernel.exception does not led to a Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.