Skip to content

[Form] Silence a legacy test. #13801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Form] Silence a legacy test. #13801

wants to merge 1 commit into from

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Feb 26, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@jakzal jakzal mentioned this pull request Feb 26, 2015
Merged
@nicolas-grekas
Copy link
Member

Is it really a legacy test? Or shouldn’t bind be renamed to submit instead?

@jakzal
Copy link
Contributor Author

jakzal commented Feb 26, 2015

Hm... checking :)

@jakzal
Copy link
Contributor Author

jakzal commented Feb 26, 2015

Actually, you're right. It was added as a bug fix for bind() (#7789), but the actual behavior is in submit().

@jakzal
Copy link
Contributor Author

jakzal commented Feb 26, 2015

I'll just add it to my other PR (#13800).

@jakzal jakzal closed this Feb 26, 2015
@jakzal jakzal deleted the form-legacy-test branch February 26, 2015 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakzal @nicolas-grekas