[FrameworkBundle] "mappings" for validation #13878

davewwww · 2015-03-09T14:42:47Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#15655
License	MIT
Doc PR

This feature allows you, to define additional validation files or directories which are not in the 'Bundle*/Resources/config/' directory.

#config.yml
framework:
  validation:
    mapping:
      files:
        - "path/to/file/validation.yml"
        - "path/to/file/validation.xml"
      dirs: 
        - "path/to/another/directory"

GromNaN · 2015-03-09T18:31:09Z

You shouldn't have to specify the file type in the config. This is already specified by the file extension.

davewwww · 2015-03-09T18:52:30Z

Ok, for the "$container->addResource()" statement I dont need the file extension.
But at the switch between "$yamlMappings[]" & "$xmlMappings[]" I need a indicator, otherwise i have to guess and that's a little bit magicly ...

davewwww · 2015-03-09T19:03:17Z

locks better?

if (preg_match('/\.(yml|xml)$/', $file, $matches)) {
    if ('yml' === $matches[1]) {
        $yamlMappings[] = $file;
    } elseif ('xml' === $matches[1]) {
        $xmlMappings[] = $file;
    }
}

GromNaN · 2015-03-09T20:08:50Z

Yes. That's the idea.

webmozart · 2015-05-04T07:38:16Z

I think the proper solution would be to rely on Puli in 3.0, if it gets included.

ZeeCoder · 2015-09-03T07:02:51Z

I would be glad to have a feature something like this. 👍
I like to separate my PHP code from basically everything else. (usually the yml conf files)
Right now I have to have the Resources/config folder in my AppBundle just to load the validation rules from there.

I would just drop that in the app/config folder, where all the other configurations reside already.

xabbuh · 2015-09-30T19:08:43Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

+                        ->arrayNode('mappings')
+                            ->prototype('array')
+                                ->children()
+                                    ->scalarNode('file')->end()


What is the reason to have an extra file key here?

in preparation for the "dir" key to include all mapping files automatically from this directory.

Why not allow to mix files and directories and make the distinction in the extension?

Or if you want to keep them separated, I would use mappings.files and mappings.dirs or something like that as different lists.

could be a solution, like is_file($path) and is_dir($path)?

mapping would become a singular in such case though, as you would have a single node for it though.

I agree with @xabbuh though. The prototyped node should not be mappings if you only configure either file or dir in it

what do you think:

framework: validation: mapping: files: - ".../validation.yml" dirs: - ".../config/validations"

fabpot · 2015-10-05T14:26:33Z

Looks like a good idea to me, @davewwww Can you take the comments into account?

davewwww · 2015-10-05T16:39:10Z

I've changed the configuration and added the directory feature.
What do you say?

stloyd · 2015-10-05T17:44:47Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

+            $files[$ext][] = $file;
+        }
+
+        if (count($files['xml']) > 0) {


IMO !empty($files['xml']) will be faster and more memory efficient.

…on to define extra validation files or directories which are not in the 'Bundle*/Resources/config' directory.

davewwww · 2015-10-06T09:58:26Z

ok, i've separated the framework-defined files from the user-defined files and removed the addResource().

xabbuh · 2015-10-06T10:04:13Z

Can you also update the XSD file of the FrameworkBundle config?

davewwww · 2015-10-06T10:19:14Z

i've never used this xsd feature.
Maybe like this:

   ...
    <xsd:complexType name="validation">
        ...
        <xsd:attribute name="mapping" type="validation_mapping" />
    </xsd:complexType>

    <xsd:complexType name="validation_mapping">
        <xsd:sequence>
            <xsd:element name="file" type="xsd:string" minOccurs="0" maxOccurs="unbounded" />
            <xsd:element name="dir" type="xsd:string" minOccurs="0" maxOccurs="unbounded" />
        </xsd:sequence>
    </xsd:complexType>
   ...

wouterj · 2016-04-16T10:18:07Z

@davewwww yes, that looks correct.

ogizanagi · 2016-06-10T13:03:58Z

Any update about this feature ?

fabpot · 2016-06-16T16:13:39Z

@davewwww Do you have time to finish this feature? It looks like we are almost there. Thanks. It would also need to be resubmitted on current master, but that should not be too difficult.

davewwww · 2016-06-17T12:29:51Z

@fabpot i created a merge request on the current master: #19086

fabpot · 2016-06-17T12:59:11Z

Thanks!

davewwww changed the title ~~"mappings" for validation~~ [FrameworkBundle] "mappings" for validation Mar 9, 2015

dunglas mentioned this pull request Mar 10, 2015

[FrameworkBundle] Serializer groups support #13107

Closed

davewwww force-pushed the 2.7 branch 6 times, most recently from 620cd61 to e7d15ac Compare March 11, 2015 12:51

aitboudad mentioned this pull request Aug 31, 2015

[RFC][Validator] Configure XML or Yaml mappings for Validator #15655

Closed

aitboudad added the Validator label Aug 31, 2015

xabbuh reviewed Sep 30, 2015
View reviewed changes

davewwww force-pushed the 2.7 branch from cb60ae1 to 69af64c Compare October 5, 2015 16:32

stloyd reviewed Oct 5, 2015
View reviewed changes

[FrameworkBundle] add "mapping" configuration key at validation secti…

5003395

…on to define extra validation files or directories which are not in the 'Bundle*/Resources/config' directory.

davewwww force-pushed the 2.7 branch from be2e58b to 5003395 Compare October 6, 2015 09:50

cs fix

31964c0

javiereguiluz added Feature FrameworkBundle labels Mar 3, 2016

fabpot closed this Jun 17, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FrameworkBundle] "mappings" for validation #13878

[FrameworkBundle] "mappings" for validation #13878

davewwww commented Mar 9, 2015

GromNaN commented Mar 9, 2015

davewwww commented Mar 9, 2015

davewwww commented Mar 9, 2015

GromNaN commented Mar 9, 2015

webmozart commented May 4, 2015

ZeeCoder commented Sep 3, 2015

xabbuh Sep 30, 2015

davewwww Oct 1, 2015

xabbuh Oct 1, 2015

xabbuh Oct 1, 2015

davewwww Oct 1, 2015

stof Oct 1, 2015

davewwww Oct 1, 2015

fabpot commented Oct 5, 2015

davewwww commented Oct 5, 2015

stloyd Oct 5, 2015

davewwww commented Oct 6, 2015

xabbuh commented Oct 6, 2015

davewwww commented Oct 6, 2015

wouterj commented Apr 16, 2016

ogizanagi commented Jun 10, 2016

fabpot commented Jun 16, 2016

davewwww commented Jun 17, 2016

fabpot commented Jun 17, 2016

[FrameworkBundle] "mappings" for validation #13878

[FrameworkBundle] "mappings" for validation #13878

Conversation

davewwww commented Mar 9, 2015

GromNaN commented Mar 9, 2015

davewwww commented Mar 9, 2015

davewwww commented Mar 9, 2015

GromNaN commented Mar 9, 2015

webmozart commented May 4, 2015

ZeeCoder commented Sep 3, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabpot commented Oct 5, 2015

davewwww commented Oct 5, 2015

Choose a reason for hiding this comment

davewwww commented Oct 6, 2015

xabbuh commented Oct 6, 2015

davewwww commented Oct 6, 2015

wouterj commented Apr 16, 2016

ogizanagi commented Jun 10, 2016

fabpot commented Jun 16, 2016

davewwww commented Jun 17, 2016

fabpot commented Jun 17, 2016