[Debug] deprecate protected ExceptionHandler::utf8Htmlize #13899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Mar 11, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
|
||
| return htmlspecialchars($str, ENT_QUOTES | (PHP_VERSION_ID >= 50400 ? ENT_SUBSTITUTE : 0), 'UTF-8'); | ||
| } | ||
|
|
||
| /** | ||
| * HTML-encodes a string | ||
| */ | ||
| private function htmlEncode($str) |
16ea8d5 to
be77b96
Compare
be77b96 to
132b3b1
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 12, 2015
…(nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] deprecate protected ExceptionHandler::utf8Htmlize | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 132b3b1 [Debug] deprecate ExceptionHandler::utf8Htmlize
| restore_error_handler(); | ||
|
|
||
| $str = iconv($charset, 'UTF-8', $str); | ||
| } |
There was a problem hiding this comment.
Two reasons: because of the function_exists check, the behavior is not deterministic, and not all strings are convertible from CP1252 to UTF-8, ("\x9D"). The code block is broken. Because of the function_exists check, this can be removed without BC pb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.