Skip to content

Fixing wrong variable name from #13519 #13927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2015

Conversation

weaverryan
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #13519
License MIT
Doc PR n/a

Hi guys!

I'm currently seeing an undefined variable in the PhpDumper on all branches. I think it was added inadvertently in #13519, so unless I'm totally missing something, this should be an easy merge.

Thanks!

@cordoval
Copy link
Contributor

nice catch 👴

@fabpot
Copy link
Member

fabpot commented Mar 15, 2015

Thank you @weaverryan.

@fabpot fabpot merged commit 3ae52ed into symfony:2.3 Mar 15, 2015
fabpot added a commit that referenced this pull request Mar 15, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Fixing wrong variable name from #13519

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13519
| License       | MIT
| Doc PR        | n/a

Hi guys!

I'm currently seeing an undefined variable in the `PhpDumper` on all branches. I think it was added inadvertently in #13519, so unless I'm totally missing something, this should be an easy merge.

Thanks!

Commits
-------

3ae52ed Fixing wrong variable name from #13519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants