[FrameworkBundle] Fix regression introduced by #13107 #13968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53ea971 to
efadac0
Compare
dunglas
added a commit
that referenced
this pull request
Mar 19, 2015
…glas) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix regression introduced by #13107 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a I've introduced a bug in 83b56f6. An error will be throw if the serializer is enabled but no cache is set. This is the fix. Commits ------- efadac0 [FrameworkBundle] Fix regression introduced by #13107
|
Doesn't this need a test to prevent future breakage? |
|
There was already a test for that but it doesn't fail I don't know why. I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've introduced a bug in 83b56f6. An error will be throw if the serializer is enabled but no cache is set.
This is the fix.