Applied the new styles to the router: commands #14132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Let me know if you need help with any. Perhaps a checklist would be useful. |
60 tasks
| { | ||
| $requirements = $route->getRequirements(); | ||
|
|
||
| $output->table( |
There was a problem hiding this comment.
there is no ->table() method in the OutputInterface. so the typehint looks weird
This was referenced Apr 5, 2015
fabpot
added a commit
that referenced
this pull request
Apr 7, 2015
…s methods (ogizanagi) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][Console][OutputStyle] Implements verbosity levels methods | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A - Travis build for #14032 | License | MIT Implements the verbosity level methods from `OutputInterface` for the new `OutputStyle` abstract class in 3.0 branch. Fixes Travis builds with `deps=high` env var for #14032 PR and future console style updates. ========= Related to: #14032, #14057, #14138, #14132, #14172, ... Commits ------- a30f507 [Console] [OutputStyle] Implements verbosity methods
|
@javiereguiluz the screenshots show a |
| array_unshift($description, '<comment>Name</comment> '.$options['name']); | ||
| array_unshift($description, $this->formatSection('router', sprintf('Route "%s"', $options['name']))); | ||
| if (isset($options['output_helper'])) { | ||
| $options['output_helper']->table($tableHeaders, $tableRows); |
There was a problem hiding this comment.
This option doesn't seem to be used?!
|
What's the status of this PR? |
|
I've updated this PR to remove the unneeded option pointed by @Tobion. |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] Fix tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - #14132 missed tests updates Commits ------- 5549f4c [FrameworkBundle] Fix tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some screenshots comparing these commands before/after.
debug:router
debug:router --show-controllers
debug:router admin_post_delete
router:match - no match
router:match - almost match
router:match - exact match
Deprecated router:dump-apache