Fixed the line length of the new Symfony Styles #14136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| return; |
There was a problem hiding this comment.
this has to be removed to comply with symfony CS
|
@javiereguiluz the class should have a way to get them from the Application IMO |
|
@stof I agree with you, but I don't know how to do it 😢 |
|
@javiereguiluz as a last resort webmozart/console/ConsoleIO.php#L56-L58 |
|
The errors reported by Travis seems to be caused by volatile tests (as reported by @stof in #14078): |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2015
…iluz) This PR was squashed before being merged into the 2.7 branch (closes #14136). Discussion ---------- Fixed the line length of the new Symfony Styles | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - **After/Before screenshots**    And now my question: is there any way to get the terminal dimensions from SymfonyStyles class without having to copy/paste the code found on \Console\Application? Commits ------- e9c7912 Fixed the line length of the new Symfony Styles
|
@javiereguiluz : Now that this PR is merged and #14032 too, Travis reports the following error :
I think this might be related to this PR ? |
|
See #14250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After/Before screenshots
And now my question: is there any way to get the terminal dimensions from SymfonyStyles class without having to copy/paste the code found on \Console\Application?