HttpCache changes for 304 responses #1414

Seldaek · 2011-06-23T09:58:12Z

stloyd · 2011-06-23T10:02:19Z

src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php

@@ -550,7 +550,7 @@ class HttpCache implements HttpKernelInterface
     */
    private function restoreResponseBody(Request $request, Response $response)
    {
-        if ('head' === strtolower($request->getMethod())) {
+        if ('HEAD' === strtoupper($request->getMethod()) || 304 === $response->getStatusCode()) {


strtoupper is unnecessary as $request->getMethod() already do it.

Right sorry, removed.

Commits ------- 7db0b95 [HttpKernel] Removed unnecessary strtoupper 0891c57 [HttpKernel] Added test 1350645 [HttpKernel] Uppercased a few http methods 05c9906 [HttpKernel] Suppress response content for 304 responses out of the cache Discussion ---------- HttpCache changes for 304 responses Fixes #1413

ghost · 2011-06-23T11:06:02Z

Thanks!

Seldaek · 2011-06-23T11:49:39Z

No problem, thanks for reporting it and doing the work of figuring out the problem :)

Seldaek added 3 commits June 23, 2011 11:23

[HttpKernel] Suppress response content for 304 responses out of the c…

05c9906

…ache Fixes symfony#1413

[HttpKernel] Uppercased a few http methods

1350645

[HttpKernel] Added test

0891c57

stloyd reviewed Jun 23, 2011
View reviewed changes

[HttpKernel] Removed unnecessary strtoupper

7db0b95

fabpot merged commit 7db0b95 into symfony:master Jun 23, 2011

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HttpCache changes for 304 responses #1414

HttpCache changes for 304 responses #1414

Seldaek commented Jun 23, 2011

stloyd Jun 23, 2011

Seldaek Jun 23, 2011

ghost commented Jun 23, 2011

Seldaek commented Jun 23, 2011

HttpCache changes for 304 responses #1414

HttpCache changes for 304 responses #1414

Conversation

Seldaek commented Jun 23, 2011

stloyd Jun 23, 2011

Choose a reason for hiding this comment

Seldaek Jun 23, 2011

Choose a reason for hiding this comment

ghost commented Jun 23, 2011

Seldaek commented Jun 23, 2011