[Debug] Add symfony_debug_backtrace() and use it when dealing with fatal errors #14159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44ef2cb to
4360139
Compare
|
Tests are green for what is related to this PR, ready to merge/vote |
|
Regarding the C extension, I still don't know what the strategy is to expose it @fabpot. IIRC, you said you would write a blog post about it a long time ago, but I don't remember seeing it. It would be great to know how we deal with them. |
4360139 to
f3f789a
Compare
6d36d0b to
b989a01
Compare
b989a01 to
5cbd9fe
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2015
…dealing with fatal errors (jpauli, nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug] Add symfony_debug_backtrace() and use it when dealing with fatal errors | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This takes a subset of #12159 that would be great in 2.7, and uses it to gather back traces of fatal errors when possible. Commits ------- 5cbd9fe [Debug] Updated CHANGELOG beb88f7 [Debug] Use symfony_debug_backtrace() in FatalErrorException when available 6487b6e [Debug] Add debug extension to the test suite eacdc62 [Debug] Add symfony_debug_backtrace() that works with fatal errors
|
Will there also be a DLL download at some point? (edit. typo) |
|
Help from someone familiar with building on Windows would be required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a subset of #12159 that would be great in 2.7, and uses it to gather back traces of fatal errors when possible.