[WebProfilerBundle] Add link to show profile of latest request #14264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35f64f3 to
40d45eb
Compare
|
👍 you need also change https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/info.html.twig#L30 when token == latest |
40d45eb to
8a8b211
Compare
|
Thanks for the review. The PR is updated to show a more precise message, if there are no profiles. |
| if ('latest' === $token) { | ||
| $latest = current($this->profiler->find(null, null, 1, null, null, null)); | ||
| $token = $latest ? $latest['token'] : $token; | ||
| } |
There was a problem hiding this comment.
I would simplify the code to:
if ('latest' === $token && $latest = current($this->profiler->find(null, null, 1, null, null, null))) {
$token = $latest['token'];
}8a8b211 to
85f1c1c
Compare
|
@fabpot I changed the code as suggested. |
|
I think this can be merged in 2.8 as it is, can't it? |
|
Thank you @xelaris. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "View latest" link next to "View last 10" to enable quick access to the profile of the latest request. This is useful especially when using the profiler along with a REST client. After sending a new request it is now possible to view the latest profile with just one click.