[Translator] Cache does not take fallback locales into consideration (sf2.3) #14268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| /* | ||
| * Because the cache file contains a catalogue including all of its fallback | ||
| * catalogues (either "inlined" in Symfony 2.7 production or "standalone"), |
There was a problem hiding this comment.
you should remove the mention of 2.7 here
As we're dumping entire catalogues including their fallbacks (standalone or inlined in ~2.7), we need to use different cache files for different sets of fallback locales.
|
Updated, thanks @stof. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @mpdude. |
aitboudad
added a commit
that referenced
this pull request
Apr 8, 2015
…sideration (sf2.3) (mpdude) This PR was merged into the 2.3 branch. Discussion ---------- [Translator] Cache does not take fallback locales into consideration (sf2.3) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14268 | License | MIT | Doc PR | n/a This is the Symfony 2.3 variant of #14267. Commits ------- 0f84f3a [Translator] Cache does not take fallback locales into consideration
aitboudad
added a commit
that referenced
this pull request
Apr 9, 2015
…t *inside* the cache (mpdude, aitboudad) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Translation] avoid freshness check based on content *inside* the cache | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT it's mainly based on #14268 Commits ------- f9939d8 [Translation] avoid freshness check based on content *inside* the cache. f666657 [Translator] Cache does not take fallback locales into consideration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Symfony 2.3 variant of #14267.