[2.7][Console] Make lineLength protected insted of private #14285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just reimplement the logic. It's 3 lines of code... |
|
Well, I do that now, but I'd rather not duplicate logic if it isn't necessary.. |
|
But protected means another extension point that needs to be maintained. So I think 3 lines of code is less a problem than one more extension point. So it's not worth to provide an extension point here. |
| @@ -32,10 +32,11 @@ class SymfonyStyle extends OutputStyle | |||
| { | |||
| const MAX_LINE_LENGTH = 120; | |||
|
|
|||
| protected $lineLength; | |||
There was a problem hiding this comment.
also it would need to be documented
|
👎 for reasons Tobion gave |
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, it can be more easily extended.
For example, I want to extend the SymfonyStyle (see laravel/framework#8338) with just some tweaks to the Symfony style. But because of the private methods, this isn't as easy to use as I would like. I'd need to access the lineLength to use a different block function.
But perhaps there is a better way?