[Form] deprecate read_only option #14403
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ea295 to
83db940
Compare
6d6edaa to
40f4440
Compare
|
@symfony/deciders ready |
|
|
||
| $readOnlyNormalizer = function (Options $options, $readOnly) { | ||
| if (null !== $readOnly) { | ||
| trigger_error('The form option "read_only" is deprecated since version 2.7 and will be removed in 3.0. Use "attr[\'readonly\']" instead.', E_USER_DEPRECATED); |
|
Shouldn't we bump the dev dependency for the Form component in the FrameworkBundle to |
|
yes |
|
Fixed |
|
Looks good! 👍 |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
May 20, 2015
This PR was squashed before being merged into the 2.8 branch (closes #14403). Discussion ---------- [Form] deprecate read_only option | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #10658 | License | MIT | Doc PR | symfony/symfony-docs#3782 Replaces #10676 with a slightly different implementation. - fixes BC break when 'read_only' => true option and at the same time custom attributes are used by using a normalizer - adds deprecation notice - keeps legacy tests Commits ------- 53330e1 [Form] deprecate read_only option
Merged
| )); | ||
|
|
||
| $html = $this->renderWidget($form->createView()); | ||
|
|
||
| // compare plain HTML to check the whitespace | ||
| $this->assertSame('<input type="text" id="text" name="text" readonly="readonly" disabled="disabled" required="required" maxlength="10" pattern="\d+" class="foobar" data-foo="bar" value="value" />', $html); | ||
| $this->assertSame('<input type="text" id="text" name="text" disabled="disabled" required="required" readonly="readonly" maxlength="10" pattern="\d+" class="foobar" data-foo="bar" value="value" />', $html); |
There was a problem hiding this comment.
I don't understand, this doesn't preserve BC here? The test was changed to support the new way (through attributes), but the old way is not tested anymore.
This created a BC break for us when migrating from 2.7 to 2.8. We have to switch from the read_only variable to the attr key.
There was a problem hiding this comment.
@mnapoli what exactly is breaking except the position in the string ? One would just expect to get the attribute here.
There was a problem hiding this comment.
Before (2.7) passing read_only as a variable was working, after (2.8) it isn't. We had to put readonly in the attr array instead.
There was a problem hiding this comment.
Here is the change we had to do:
{% block _form_category_name_widget %}
- {% set read_only = true %}
{% set attr = {
'data-target-show': '.choose-categories',
+ 'readonly': true,
} %}
{{ block('form_widget_simple') }}
{% endblock %}
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Mar 23, 2016
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Mar 23, 2016
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Mar 25, 2016
fabpot
added a commit
that referenced
this pull request
Mar 27, 2016
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fix BC break introduced in #14403 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- 5f48c6a [Form] Fix BC break introduced in #14403
fabpot
added a commit
that referenced
this pull request
Mar 27, 2016
* 2.8: improved comment [FileSystem] Add support for Google App Engine. [2.8] fix mocks [Form] Fix BC break introduced in #14403
fabpot
added a commit
that referenced
this pull request
Mar 27, 2016
* 3.0: bumped Symfony version to 2.8.5 updated VERSION for 2.8.4 updated CHANGELOG for 2.8.4 Revert "bug #18275 [Form] Fix BC break introduced in #14403 (HeahDude)" improved comment [FileSystem] Add support for Google App Engine. [2.8] fix mocks bumped Symfony version to 2.7.12 [Form] Fix BC break introduced in #14403 updated VERSION for 2.7.11 updated CHANGELOG for 2.7.11 [Request] Fix support of custom mime types with parameters fix mocks fix mocks [Validator] do not treat payload as callback
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #10676 with a slightly different implementation.