[2.7][Form] Patch label_attr in choice_attr. Fix #14404, #14165, #14393 #14405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,3 +6,4 @@ package*.tar | |||
| packages.json | |||
| phpunit.xml | |||
| /vendor/ | |||
| /.idea | |||
There was a problem hiding this comment.
this belongs into your own global ignore
| // Resolve label_attr to the right level | ||
| if (isset($choiceOpts['attr']['label_attr'])) { | ||
| $choiceOpts['label_attr'] = $choiceOpts['attr']['label_attr']; | ||
| unset($choiceOpts['attr']['label_attr']); |
There was a problem hiding this comment.
this is not the correct thing. the attr is for html attributes. but label_attr doesn't exist as html attr.
To support your use-case, we would need to add another option: choice_label_attr with the same logic as the other choice options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label_attrtochoice_attrwhen choice field is expanded for radio buttons and checkboxes labels, [2.7][Form] label_attr in choice_attr for choice field when expanded #14404placeholderoption inChoiceType, when required set to false causes validation error, [Form] unintended validation BC break by #14050 #14165, [2.7] [Form] Regression on non required ChoiceType handling #14393