[DX] Switch user from the WDT #14458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a link to switch back
| <b>Switch to user</b> | ||
| <a href="?_switch_user=_exit" title="Switch back">Exit</a> | ||
| </div> | ||
| {% elseif 'ROLE_ALLOWED_TO_SWITCH' in collector.roles %} |
There was a problem hiding this comment.
it won't work when the role is modified
# app/config/security.yml
security:
firewalls:
main:
switch_user: { role: ROLE_ADMIN }There was a problem hiding this comment.
Exact. Added to the todo list. That goes with the customization of the request parameter.
|
I close this PR as it is too complex to handle configurable roles and query parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before going further, I would like to get your opinion on this feature.
When working with user permissions, it's very convenient to switch between roles and the impersonating feature of Symfony is really useful for that.
http://symfony.com/doc/current/cookbook/security/impersonating_user.html
Input field to choose the user to impersonate
Link to quit and return to the previous user
TODO LIST:
_switch_user)isGrantedinstead of looking at the list of rolesROLE_ALLOWED_TO_SWITCH)