[DependencyInjection] Removed extra strtolower calls #14470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -686,7 +686,7 @@ public function setAlias($alias, $id) | |||
| throw new InvalidArgumentException('$id must be a string, or an Alias object.'); | |||
| } | |||
|
|
|||
| if ($alias === strtolower($id)) { | |||
| if ($alias === $id) { | |||
There was a problem hiding this comment.
this seems wrong: string === Alias can never be true
There was a problem hiding this comment.
Done, casted $id to a string and added a missing test for this condition.
|
|
|
@Tobion agree, btw you know the reason why in some hassers |
|
to support |
|
Thank you @dosten. |
fabpot
added a commit
that referenced
this pull request
Apr 27, 2015
…sten) This PR was squashed before being merged into the 2.3 branch (closes #14470). Discussion ---------- [DependencyInjection] Removed extra strtolower calls | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - `Alias` already lowercase the `$id` in the constructor. Using `ContainerBuilder::hasAlias()` and `ContainerBuilder::hasDefinition()` inside the code makes an extra strtolower call. Commits ------- 3bfbf45 [DependencyInjection] Removed extra strtolower calls
fabpot
added a commit
that referenced
this pull request
Aug 22, 2016
This PR was squashed before being merged into the 2.7 branch (closes #19689). Discussion ---------- [DI] Cleanup array_key_exists | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | comma-separated list of tickets fixed by the PR, if any | License | MIT | Doc PR | reference to the documentation PR, if any Investigated this a bit, and to me it looks like left-over code. `null` doesnt end up in `$this->services` by design (this was done in #8582) so it seems. The test added then for regression still passes :) I cant believe we guarantee BC for users doing `$this->services['id'] = null` (due protected), allowing them to break the design of `has`, `get` and `initialized` right now. This also happens for `$this->definitions` in `ContainerBuilder`, maybe because `Container` did it alteady.. but im not sure. Then again, there's this comment: #14470 (comment) Commits ------- 3306c70 [DI] Cleanup array_key_exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliasalready lowercase the$idin the constructor. UsingContainerBuilder::hasAlias()andContainerBuilder::hasDefinition()inside the code makes an extra strtolower call.