Some feedback?

Thank you for the PR @dosten! As I said in the ticket, I don't want to deprecate Date and Time. Apart from that, this PR looks good.

The UPGRADE-2.8.md need to be removed too?

@webmozart done, if a want to add a violation to a validator is this considered a BC break? Ex: DateTime::getLastErrors() returns an error when the timezone is invalid, in this PR is mapped as a INVALID_FORMAT_ERROR, but i want to submit another PR to add a INVALID_TIMEZONE_ERROR.

ping @webmozart

ping @webmozart

Any feedback on this?

Looks good to me. But doesn't it make sense to also have the same option in the Date constraint?

@xabbuh My first idea was to deprecate the Date and Time constraints because we can do the same with this constraint now. If i add this to the Date (or Time) constraint IMO we would have two constraints that can do the same.

use Symfony\Component\Validator\Constraints\Date;
use Symfony\Component\Validator\Constraints\DateTime;
use Symfony\Component\Validator\Constraints\Time;

// This constraints are equivalent.
$constraint = new DateTime(['format' => 'Y-m-d']);
$constraint = new Date();

// This constraints are equivalent.
$constraint = new DateTime(['format' => 'H:i:s']);
$constraint = new Time();

@dosten What you describe will actually be the case right now with only having the format option in the DateTime constraint.

Edit: I mean, we could now indeed use the DateTime constraint to check for only the date or the time, but if we don't deprecate the Date and Time constraints it feels a bit awkward that one would have to use the DateTime constraint if they want to have a custom date format while they could use the Date constraint if the format doesn't need to be customised.

I agree with @xabbuh on the deprecation of Date and Time. It's probably best instead of having multiple ways of validating the same type of value.

I agree with you, IMO we should deprecate these constraints.

Can you check this @webmozart ? We can merge this one and discuss the deprecation of the other constraints in another issue?

ping someone

Closed in favor of #17553