[UPGRADE] Mention the CSS strategy and it's effects #14666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 :) |
|
Does it concern only CSS or may it involve also other mime types, like js ? |
| ```css | ||
| {# styles.css.twig #} | ||
|
|
||
| {# with brand_Color: '#123456' #} |
There was a problem hiding this comment.
typo:
- brand_Color
+ brand_color|
@Pierstoval the JS strategy is automatically applied for JS files in all Symfony versions (or at least, it was already applied before Symfony 2.7). |
|
@Pierstoval : AFAIU, js was already handled correctly: #13141, but css handling was only introduced in symfony >=2.7 which dropped Twig <1.18 support. EDIT: too slow. :) |
|
Thank you @wouterj. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS strategy, which is automatically applied to Twig CSS files as of Symfony 2.7, results in different behaviour when outputting reserved characters like
#123456. This has to be documented in the UPGRADE file.See https://github.com/javiereguiluz/EasyAdminBundle/pull/305 for an example.