Skip to content

[Translator] changed the visibility of the locale from protected to private. #14668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Translator] changed the visibility of the locale from protected to private. #14668

wants to merge 1 commit into from

Conversation

aitboudad
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets ~
Tests pass? yes
License MIT

@mpdude
Copy link
Contributor

mpdude commented May 18, 2015

That's a BC break, isn't it?

@aitboudad
Copy link
Contributor Author

Reduce visibility for a protected property is allowed http://symfony.com/doc/current/contributing/code/bc.html#changing-classes

@stof
Copy link
Member

stof commented May 18, 2015

@aitboudad no it is not. The Translator is tagged as @api (if you are not sure about which category the class is, use the API column of the table. This is the column being really BC)

@aitboudad
Copy link
Contributor Author

I see it now so, I'll make the change in 3.0.

@aitboudad aitboudad closed this May 18, 2015
@aitboudad aitboudad deleted the translation_dep_locale branch May 19, 2015 11:24
@aitboudad
Copy link
Contributor Author

see #14693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @mpdude @stof