Skip to content

[Translator] create one catalogue per locale in the prod environment. #14725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Translator] create one catalogue per locale in the prod environment. #14725

wants to merge 1 commit into from

Conversation

aitboudad
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #13897 (comment)
Tests pass? yes
License MIT

@aitboudad aitboudad mentioned this pull request May 22, 2015
Closed
@mpdude
Copy link
Contributor

mpdude commented May 22, 2015

I think this is wrong. Different translators with different resources and fallback locale orders will share the same cache.

@stof
Copy link
Member

stof commented May 22, 2015

@mpdude this is already the case in previous versions of Symfony. If you have different translator instances, you need to use separate cache folders for them already

@aitboudad
Copy link
Contributor Author

closed in favor #14705

@aitboudad aitboudad closed this May 31, 2015
@aitboudad aitboudad deleted the translation_fix_wrong_file_path branch May 31, 2015 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @mpdude @stof