Add more details on directory creation failures #14728
Conversation
|
https://travis-ci.org/symfony/symfony/jobs/63667867 Warning: This development build of composer is over 30 days old. It is recommended to update it by running "/home/travis/.phpenv/versions/5.3.3/bin/composer self-update" to get the latest version. Who should we inform about this? |
|
This can only be merged in 2.8 as it changes the behavior of the code. |
|
👍 |
👍 do you want me to open a new PR against master? |
|
No, no need to create a PR on master, 2.8 is merged into master on a regular basis. |
|
|
||
| if (null !== $this->debugger) { | ||
| $this->debugger->log(sprintf('Storing template "%s" in cache', $template->get('name'))); | ||
| $this->debugger->log(sprintf('Stored template "%s" in cache; %s', $template->get('name'), false === $writeResult ? 'failed' : 'success')); |
|
@SpacePossum why did you close this PR? |
|
@nicolas-grekas I closed it because it needs rework and I didn't want to bother any more people with the PR until I've done that. Could you give you opinion on my suggestion #14728 (comment) , it would help me to get back on this one:) |
(* that is a bit of a lie, there are lot of Yaml parsing test failing locally but those are not related)