[TwigBundle] Reconfigure twig paths when they are updated #14778
Conversation
Directory's content and modification time are not considered any more for freshness check. Only it's creation or deletion are now checked. This addresses performance issues (#14771, #14768), and also improves the cases were container is reconfigured as directory creation needed clearing the cache manually (#14262).
|
SemVer wise, it would be better to have this in 2.7 or 2.8 so others can depend on that minor version bump if they want to use the new resource type. I assume you based it on 2.3 because that already merged (and released?) a change that causes the performance problem? |
|
So not quite sure, but maybe |
|
Adding new features in the Config component in a patch release is a no-go. It will be very hard to write a constraint to use this new feature (it would be |
|
If the performance impact is huge, that might include reverting the changes mentioned above, which have already been released in a bugfix. |
|
OK, so you revert #14262 and I add this patch, as a feature, on branch 2.8 ? |
|
It might not be of any help, but i'm also experiencing bad performance in dev env since version 2.3.29, and the mentionned commit clearly is responsible of this behavior. |
|
We should:
|
|
PR reverted |
|
A new 2.3.x will be tag ? |
|
Did make the proper PR on 2.8 in #14781. I'm closing this PR. |
…ted (chbruyand) This PR was squashed before being merged into the 2.8 branch (closes #14781). Discussion ---------- [TwigBundle] Reconfigure twig paths when they are updated | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14771, #14768, #14262, #14778 | License | MIT Refresh twig paths upon creation and deletion. As we don't care neither about path's modification time nor path's content, a new Resource has been added in the Config Component. Full discussion in #14778. Commits ------- 3cbff05 [TwigBundle] Reconfigure twig paths when they are updated
Directory's content and modification time are not considered any more for freshness check. Only it's creation or deletion are now checked.
This addresses performance issues (#14771, #14768), and also improves the cases were container is reconfigured as directory creation needed clearing the cache manually (#14262).